fix: consider the case where deliveries can be an empty list #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankiyani
commented
Dec 30, 2024
shankiyani
force-pushed
the
shankiyani/empty-deliveries
branch
from
776044d to
0b1ff3c
Compare
capri-xiyue
approved these changes
Dec 30, 2024
Merged
token-minter-prod bot
added a commit
that referenced
this pull request
Jan 24, 2025
## What's Changed * chore: update minty config to use issuers variable by @bradegler in #346 * support latest alert changes by @shankiyani in #347 * remove webhook forward progress alert by @shankiyani in #348 * chore: fix ci and clean workflows by @verbanicm in #351 * build(deps): bump golang.org/x/crypto from 0.24.0 to 0.31.0 in the go_modules group across 1 directory by @dependabot in #350 * fix: consider the case where deliveries can be an empty list by @shankiyani in #353 * disable 4xx alert policy by @shankiyani in #354 * fix: dont override checkpoint if list deliveries is empty by @shankiyani in #355 * Remove shadowed loop variables by @sethvargo in #356 * Update all deps by @sethvargo in #357 * chore: upgrade GitHub app code to latest version from pkg by @bradegler in #358 * chore: upgrade to version 1.3.1 of pkg by @bradegler in #359 * Add checks to avoid referencing "null" values by @ian-shafer in #360 ## New Contributors * @ian-shafer made their first contribution in #360 **Full Changelog**: v0.0.30...v0.0.31 Co-authored-by: token-minter-prod[bot] <125072751+token-minter-prod[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.